"Made by player" admin setting being ignored on https://eternagame.org/puzzles

Feedback Bug Reports
1

Not make by player
Not make by player1106×367 42.6 KB

Puzzles without Made by Player checked on the Drupal page shouldn’t be attributed to a specific person.

2

admin? what admin settings

3

You can only see them if you are an admin.

4

Ah! what does it look like if you’re admin?

5

It’s not pretty – a vertical list of input fields,. Most are text fill-ins, even if there are only two acceptable choices.

… and there is virtually no input validation. :rofl:

6

That’s an issue I’ve fixed and made a pull request for. Should be merged soon

1 Like
7

ahalb is an ADMIN!?!?!?!? woahhhHhh

8

I didn’t fix the admin view, just fixed the player/avatar showing up when an admin has marked the puzzle as not made by a player

1 Like
9

Don't credit individual if "Made by player" field is not set
Don't credit individual if "Made by player" field is not set1297×599 41.7 KB

Here’s another case where a puzzle shouldn’t be credited if the “Made by player” field isn’t set.

10

Weird, that was supposed to have been resolved - I’ll have to dig into what the issue is

11

Note that this is a different page, not covered in my original report.

12

Yeah I’m aware - Alex removed it on both, and I thought I verified that

13

I think I see what’s going on. On the legacy site, a blank was interpreted as false (not made by player); with the new, it’s interpret as true.

14

Ah - that can be easily remedied.